Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(we-made-this): add serverless transactional message app #2182

Merged
merged 1 commit into from
May 2, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented May 1, 2023

Issue number: #2180

Summary

Changes

Please provide a summary of what's being changed

Added the new code sample.

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner May 1, 2023 08:59
@rubenfonseca rubenfonseca requested review from heitorlessa and removed request for a team May 1, 2023 08:59
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 1, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2023
@rubenfonseca rubenfonseca linked an issue May 1, 2023 that may be closed by this pull request
1 task
@san99tiago
Copy link

Hi @heitorlessa , @rubenfonseca . I have succesfully implemented and tested the suggestions. You can double check them with this PR:

Let me know if additional requirements are needed. I appreciate the given feedback and taking the time to read the code!

@rubenfonseca rubenfonseca merged commit 28ca40a into develop May 2, 2023
@rubenfonseca rubenfonseca deleted the rf/2180 branch May 2, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[I Made This]: Serverless Transactional Messages App
3 participants