Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(batch): fixed typo in DynamoDB Streams section #2189

Merged
merged 1 commit into from
May 2, 2023

Conversation

arjanschaaf
Copy link
Contributor

The "Processing messages from DynamoDB" paragraph mentioned "Kinesis" instead of "DynamoDB Streams"

Issue number: #2188

Summary

DynamoDB Streams paragraph contained reference to Kinesis.

Changes

Replaced Kinesis reference with DynamoDB Streams

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

The "Processing messages from DynamoDB" paragraph mentioned "Kinesis" instead of "DynamoDB Streams"

Signed-off-by: arjanschaaf <arjanschaaf@users.noreply.github.com>
@arjanschaaf arjanschaaf requested a review from a team as a code owner May 2, 2023 07:18
@arjanschaaf arjanschaaf requested review from leandrodamascena and removed request for a team May 2, 2023 07:18
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 2, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2023
@heitorlessa heitorlessa changed the title docs(batch): fixed typo docs(batch): fixed typo in DynamoDB Streams section May 2, 2023
@heitorlessa heitorlessa requested review from heitorlessa and removed request for leandrodamascena May 2, 2023 07:27
@heitorlessa
Copy link
Contributor

Gotta say I commend your bias for action... literally 5m later you found it ;) More of that please, Arjan!

@heitorlessa heitorlessa linked an issue May 2, 2023 that may be closed by this pull request
1 task
@heitorlessa heitorlessa merged commit d109c6c into aws-powertools:develop May 2, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Typo in Batch Processing guide
2 participants