Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): standardize lambda handler function name #2192

Merged
merged 2 commits into from
May 3, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2191

Summary

Changes

This PR changes the default Lambda Handler in Logger and Tracer examples.

User experience

BEFORE
image

AFTER
image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner May 2, 2023 21:08
@leandrodamascena leandrodamascena requested review from heitorlessa and removed request for a team May 2, 2023 21:08
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 2, 2023
@leandrodamascena leandrodamascena changed the title docs(examples): change the default Lambda handler in examples docs(examples): change the default Lambda Handler in Tracer and Logger examples May 2, 2023
@leandrodamascena leandrodamascena linked an issue May 2, 2023 that may be closed by this pull request
1 task
@@ -5,7 +5,7 @@ Description: AWS Lambda Powertools Metrics doc examples
Globals:
Function:
Timeout: 5
Runtime: python3.9
Runtime: python3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for that attention to detail!! <3

@heitorlessa heitorlessa changed the title docs(examples): change the default Lambda Handler in Tracer and Logger examples docs(examples): standardize lambda handler function name May 3, 2023
@heitorlessa heitorlessa merged commit 68c8562 into aws-powertools:develop May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Change default Lambda Handler in logger and tracer documentation
2 participants