fix(shared): move to static version bumping to prevent issues with customers custom builds #2386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2381
Summary
This addresses an issue with custom Python builds that remove
METADATA
folder makingimportlib
fail when assessing versioning - e.g.,serverless-python-requirements
plugin from Serverless framework.Instead, we move to statically bump version with a poetry plugin, similar to bump2version strategy, but contained within
pyproject.toml
.Changes
version.py
file changed in the release in the PR processpipx inject
in a testing release pipelineUser experience
Nothing changes except it's bulletproof from anyone removing
METADATA
folder.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.