Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): move to static version bumping to prevent issues with customers custom builds #2386

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 6, 2023

Issue number: #2381

Summary

This addresses an issue with custom Python builds that remove METADATA folder making importlib fail when assessing versioning - e.g., serverless-python-requirements plugin from Serverless framework.

Instead, we move to statically bump version with a poetry plugin, similar to bump2version strategy, but contained within pyproject.toml.

Changes

Please provide a summary of what's being changed

  • Safely add poetry plugin to dev setup
  • Safely add poetry plugin as part of release process setup
  • Include version.py file changed in the release in the PR process
  • Test pipx inject in a testing release pipeline

User experience

Please share what the user experience looks like before and after this change

Nothing changes except it's bulletproof from anyone removing METADATA folder.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner June 6, 2023 07:50
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team June 6, 2023 07:50
@boring-cyborg boring-cyborg bot added commons dependencies Pull requests that update a dependency file internal Maintenance changes labels Jun 6, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2023
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for rubenfonseca June 6, 2023 07:51
@heitorlessa heitorlessa marked this pull request as draft June 6, 2023 07:51
@heitorlessa
Copy link
Contributor Author

Two more tasks to complete

@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (8b71185) 97.18% compared to head (ba64c03) 97.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2386      +/-   ##
===========================================
- Coverage    97.18%   97.18%   -0.01%     
===========================================
  Files          153      153              
  Lines         7008     7003       -5     
  Branches       514      499      -15     
===========================================
- Hits          6811     6806       -5     
  Misses         156      156              
  Partials        41       41              
Impacted Files Coverage Δ
aws_lambda_powertools/shared/version.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2023
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jun 6, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2023
@heitorlessa heitorlessa marked this pull request as ready for review June 6, 2023 08:42
@leandrodamascena leandrodamascena merged commit 8f0b808 into aws-powertools:develop Jun 6, 2023
sthulb pushed a commit that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working commons dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants