Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(navigation): standardize link targets to enhance customer experience #2420

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Jun 8, 2023

Issue number: #2260

Summary

Changes

This PR aims to enhance the user experience by implementing a standardized navigation approach for our documentation.

Currently, there are variations in how links are handled, with some opening in the same tab and others opening in a new tab using target="_blank". By establishing a consistent navigation standard, we can ensure a seamless and intuitive user experience. This PR proposes the following guidelines:

1 - Anchors - we will not use {target="_blank"}
2 - Links to other sections of the Powertools documentation - we will use {target="_blank"}
3 - Links to external Amazon/AWS documentation or Github AWS repositories - we'll use {target="_blank"}
4 - Third-party links - we will use {target="_blank"}

@heitorlessa, thanks for suggesting the plugin https://github.com/JakubAndrysek/mkdocs-open-in-new-tab, but there is a known issue with navigation.instant feature and we use this.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner June 8, 2023 01:29
@leandrodamascena leandrodamascena requested review from rubenfonseca and removed request for a team June 8, 2023 01:29
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Jun 8, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2023
@leandrodamascena leandrodamascena linked an issue Jun 8, 2023 that may be closed by this pull request
1 task
@leandrodamascena leandrodamascena requested review from heitorlessa and removed request for rubenfonseca June 8, 2023 01:31
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (824912b) 97.18% compared to head (c572651) 97.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2420   +/-   ##
========================================
  Coverage    97.18%   97.18%           
========================================
  Files          153      153           
  Lines         7008     7008           
  Branches       513      513           
========================================
  Hits          6811     6811           
  Misses         156      156           
  Partials        41       41           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heitorlessa heitorlessa changed the title docs(navigation): enhancing the user experience by standardizing documentation navigation docs(navigation): standardize link targets to enhance customer experience Jun 8, 2023
@heitorlessa
Copy link
Contributor

looking 👀

@heitorlessa
Copy link
Contributor

Thank you for this, great work! One ask I'd have is to create an issue in the mkdocs-material for guidance on how to resolve this properly with a plugin - we have no guarantees we might miss this at some point. We're also missing a section in MAINTAINERS and CONTRIBUTING to mention this standard.

@heitorlessa heitorlessa merged commit f0dcb8f into aws-powertools:develop Jun 8, 2023
sthulb pushed a commit that referenced this pull request Jun 19, 2023
…ence (#2420)

Co-authored-by: erikayao93 <erikayao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Define a standard navigation on documentation pages.
4 participants