Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(idempotency): add cdk table example #2434

Merged
merged 8 commits into from
Jun 15, 2023
Merged

docs(idempotency): add cdk table example #2434

merged 8 commits into from
Jun 15, 2023

Conversation

ran-isenberg
Copy link
Contributor

@ran-isenberg ran-isenberg commented Jun 10, 2023 •
edited by rubenfonseca
Loading

Issue number: #2433

Summary

Added CDK construct example for idempotency setup

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ran-isenberg ran-isenberg requested a review from a team as a code owner June 10, 2023 07:11
@ran-isenberg ran-isenberg requested review from leandrodamascena and removed request for a team June 10, 2023 07:11
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jun 10, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2023
@ran-isenberg
Copy link
Contributor Author

please note that the other long lines changes that i did were because the linter just failed. feel free to revet them.
This is the error i got:

  • hook id: markdownlint
  • exit code: 1

docs/utilities/idempotency.md:361:266 MD013/line-length Line length [Expected: 265; Actual: 273]
docs/utilities/idempotency.md:437:266 MD013/line-length Line length [Expected: 265; Actual: 320]
docs/utilities/idempotency.md:445:266 MD013/line-length Line length [Expected: 265; Actual: 284]

@rubenfonseca rubenfonseca self-assigned this Jun 13, 2023
@rubenfonseca rubenfonseca linked an issue Jun 13, 2023 that may be closed by this pull request
Docs: Idempotency CDK example #2433
Closed
1 task
@rubenfonseca
Copy link
Contributor

Looking at this now.

rubenfonseca
rubenfonseca suggested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work Ran! Left a couple of comments. Do you mind moving the snippets to example/? Let me know if you need a hand with this!

docs/utilities/idempotency.md Show resolved Hide resolved
docs/utilities/idempotency.md Show resolved Hide resolved
docs/utilities/idempotency.md Outdated Show resolved Hide resolved
@rubenfonseca rubenfonseca added the idempotency Idempotency utility label Jun 14, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2023
@ran-isenberg
Copy link
Contributor Author

@rubenfonseca i moved them as snippets. However, sam had plenty of cloudformation lint errors (even though it's not cloudformation). so i pasted an empty file.
i dunno how to fill the sam part anyways.

BTW, i saw that you guys added a vpc lattice model but no parser variation :(

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023
@rubenfonseca
Copy link
Contributor

Thank you for this great addition Ran!

@rubenfonseca rubenfonseca merged commit 7cd1812 into aws-powertools:develop Jun 15, 2023
@ran-isenberg ran-isenberg deleted the idempotent branch June 15, 2023 13:54
sthulb pushed a commit that referenced this pull request Jun 19, 2023
@ran-isenberg @rubenfonseca @sthulb
docs(idempotency): add CDK example (#2434)
bf58ae1 
Co-authored-by: Ran Isenberg <ran.isenberg@ranthebuilder.cloud>
Co-authored-by: Ruben Fonseca <rubefons@amazon.com>
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
@ran-isenberg @rubenfonseca @rafaelgsr
docs(idempotency): add CDK example (aws-powertools#2434)
762f6af 
Co-authored-by: Ran Isenberg <ran.isenberg@ranthebuilder.cloud>
Co-authored-by: Ruben Fonseca <rubefons@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenfonseca rubenfonseca rubenfonseca approved these changes

@leandrodamascena leandrodamascena Awaiting requested review from leandrodamascena leandrodamascena was automatically assigned from awslabs/aws-lambda-powertools-python

Assignees

@rubenfonseca rubenfonseca

Labels
documentation Improvements or additions to documentation idempotency Idempotency utility size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Idempotency CDK example
2 participants
@ran-isenberg @rubenfonseca