-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): add support to VpcLatticeModel #2584
feat(parser): add support to VpcLatticeModel #2584
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2584 +/- ##
========================================
Coverage 97.21% 97.22%
========================================
Files 158 160 +2
Lines 7370 7394 +24
Branches 537 537
========================================
+ Hits 7165 7189 +24
Misses 158 158
Partials 47 47
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leandro for the quick turn-around! Just left two small comments. What do you think?
aws_lambda_powertools/utilities/parser/envelopes/vpc_lattice.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/parser/envelopes/vpc_lattice.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Leandro Damascena <lcdama@amazon.pt>
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Leandro Damascena <lcdama@amazon.pt>
I agree 100%, Ruben! All of them were addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Co-authored-by: Ruben Fonseca <rubefons@amazon.com>
Issue number: #2579
Summary
Changes
Use case:
Customers can integrate VPC Lattice with Lambda and might need to parser events using Pydantic.
Changes:
This pull request introduces support to the VPCLatticeModel and envelope.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.