Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable Ruff rules ISC, I001, B018 and fix the errors #2597

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2534

Summary

Changes

Enabling Ruff rules

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner June 27, 2023 14:40
@boring-cyborg boring-cyborg bot added the tests label Jun 27, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jun 27, 2023
@leandrodamascena leandrodamascena linked an issue Jun 27, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (e6a999e) 97.22% compared to head (b90c4ae) 97.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2597      +/-   ##
===========================================
- Coverage    97.22%   97.22%   -0.01%     
===========================================
  Files          160      160              
  Lines         7394     7392       -2     
  Branches       537      537              
===========================================
- Hits          7189     7187       -2     
  Misses         158      158              
  Partials        47       47              
Impacted Files Coverage Δ
aws_lambda_powertools/utilities/batch/types.py 80.00% <100.00%> (-1.25%) ⬇️
...ools/utilities/idempotency/persistence/dynamodb.py 98.80% <100.00%> (ø)
...s_lambda_powertools/utilities/parser/models/sns.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests pass, great work Leandro!

@rubenfonseca rubenfonseca merged commit c111590 into aws-powertools:develop Jun 27, 2023
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Ruff rules ISC and I001 and fix the errors
3 participants