Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): prevent sast codeql to run in forks #2711

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 7, 2023

Issue number: #2203

Summary

CodeQL (SAST) is running on forks pull requests. This PR ensures it only runs for the origin.

This is part of the OSSF Scorecard investigation to understand why SAST isn't running on our commits: https://gist.github.com/heitorlessa/04a4f1bd6b9c9185455c85ce77f13147

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner July 7, 2023 09:50
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 7, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jul 7, 2023
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team July 7, 2023 09:54
@heitorlessa heitorlessa merged commit 66b1dc8 into aws-powertools:develop Jul 7, 2023
@heitorlessa heitorlessa deleted the fix/codeql-on-forks branch July 7, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants