Skip to content

docs(event_handlers): new data validation and OpenAPI feature #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Nov 23, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Nov 21, 2023

Issue number: #3324

Summary

Changes

Please provide a summary of what's being changed

This PR adds documentation for the validation and OpenAPI features.

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Todo list

  •  separate validation documents and include them as part of the REST API docs
  • rebase the changes with develop

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Nov 21, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 21, 2023
@rubenfonseca rubenfonseca linked an issue Nov 21, 2023 that may be closed by this pull request
1 task
@rubenfonseca rubenfonseca marked this pull request as ready for review November 22, 2023 08:46
@rubenfonseca rubenfonseca requested a review from a team November 22, 2023 08:46
@heitorlessa
Copy link
Contributor

heitorlessa commented Nov 22, 2023

Adding here to more easily orient progress

  • Extract data validation and move under Getting Started
    • Install section
    • Explain how to use it
    • Explain Payload data validation
    • Explain validation errors
      • Demonstrate standard validation error
      • Override validation errors
    • Explain Query string data validation
    • Explain Path data validation
  • Extract Swagger UI and move under Getting Started
  • Extract OpenAPI to Advanced
  • Extract OpenAPI parameters
  • Confirm whether we can make Swagger UI dynamic routes param work with our <param>
  • Test code snippets with real deployment
  • Extract embed=True and create a new section altogether
  • List out what features don't work with data validation for update
  • Convert snippets to use REST Resolver instead of HTTP
    • Resolver name
    • Input
    • Output
  • Update key features section
  • [ ] Move back OpenAPI to their specific section
    • Improve intro
    • Link back to data validation section
    • Revisit examples

heitorlessa and others added 20 commits November 22, 2023 12:29
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa
Copy link
Contributor

adding Swagger UI routes in getting started template that I forgot 🤦🏻

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89a92b7) 95.41% compared to head (345fd0b) 95.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3386      +/-   ##
===========================================
- Coverage    95.41%   95.39%   -0.03%     
===========================================
  Files          209      209              
  Lines         9648     9648              
  Branches      1770      809     -961     
===========================================
- Hits          9206     9204       -2     
- Misses         329      330       +1     
- Partials       113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heitorlessa heitorlessa changed the title chore(docs): added validation and OpenAPI docs docs(event_handlers): new data validation and OpenAPI feature Nov 23, 2023
@rubenfonseca rubenfonseca merged commit 765781c into develop Nov 23, 2023
@rubenfonseca rubenfonseca deleted the rf/openapi-docs branch November 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation event_handlers size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: New Data validation for Event Handler REST
3 participants