-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): add support for multiValueQueryStringParameters in OpenAPI schema #3667
feat(event_handler): add support for multiValueQueryStringParameters in OpenAPI schema #3667
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3667 +/- ##
===========================================
+ Coverage 95.57% 95.65% +0.07%
===========================================
Files 214 214
Lines 9993 10031 +38
Branches 1827 1840 +13
===========================================
+ Hits 9551 9595 +44
+ Misses 329 326 -3
+ Partials 113 110 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job diving deep into OpenAPI :D Just left some small things
aws_lambda_powertools/event_handler/middlewares/openapi_validation.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/event_handler/middlewares/openapi_validation.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/event_handler/middlewares/openapi_validation.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/bedrock_agent_event.py
Outdated
Show resolved
Hide resolved
examples/event_handler_rest/src/working_with_multi_query_values.py
Outdated
Show resolved
Hide resolved
Thanks @rubenfonseca! Can you review it again pls? |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, I've also checked the highlights in the documentation and it looks good!
Issue number: #3622
Summary
Changes
This pull request enhances the OpenAPI utility by introducing support for
multiValueQueryStringParameters
in the OpenAPI schema. Previously, our utility encountered issues parsing multi-value query fields, leading to errors for customers attempting to utilize such fields. Work did:User experience
Using the code below now we can validate multi value param.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.