Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-handler): strip whitespace from Content-Type headers during OpenAPI schema validation #3677

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #3672

Summary

Changes

In this pull request, we have resolved an issue related to the handling of Content-type headers within the OpenAPI schema validation process in the event handler. The problem was associated with extra spaces preceding the Content-type value, which could lead to compatibility issues.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 29, 2024 16:25
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rubenfonseca rubenfonseca changed the title fix(event-handler): fix Content-type header space issue in OpenAPI schema validation fix(event-handler): strip whitespace from Content-Type headers during OpenAPI schema validation Jan 29, 2024
@leandrodamascena leandrodamascena merged commit a7c2a75 into aws-powertools:develop Jan 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_handlers size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: REST Event Handler doesn't handle some json parsing exceptions
2 participants