Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): create one layer artifact per region & merge #3808

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Feb 20, 2024

Issue number: #3780

Summary

This PR addresses the new racing condition introduced in upload-artifact@v4.

Previously, we were updating every Layer ARN deployment output to the same artifact name. In V4, an explicit overwrite flag is required, which raises on race conditions (good behavior!).

Now, we upload every layer artifact with the region suffix, then merge all artifacts upon download. Everything else remains the same.

Changes

Please provide a summary of what's being changed

  • Write-only instead of append layer artifact txt
  • Use region suffix on upload-artifact
  • Use pattern instead of name in download-artifact to be able to merge multiple artifacts

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner February 20, 2024 09:22
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Feb 20, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2024
@heitorlessa
Copy link
Contributor Author

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for teaming up.

It's been fun!

@heitorlessa heitorlessa linked an issue Feb 20, 2024 that may be closed by this pull request
2 tasks
@heitorlessa heitorlessa merged commit 6695932 into aws-powertools:develop Feb 20, 2024
5 checks passed
@heitorlessa heitorlessa deleted the fix/layer-actions branch February 20, 2024 09:32
@heitorlessa heitorlessa added the bug Something isn't working label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github-actions Pull requests that update Github_actions code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Layer ARN release update is partially working
3 participants