-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): create one layer artifact per region & merge #3808
fix(ci): create one layer artifact per region & merge #3808
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
We carried out tests on a separate @dreamorosi repo: https://github.com/dreamorosi/actions-playground/blob/c2189e306b4b657b52cc650dec7123cc780cb061/.github/workflows/test.yml#L60 TypeScript related PR: aws-powertools/powertools-lambda-typescript#2095 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for teaming up.
It's been fun!
Issue number: #3780
Summary
This PR addresses the new racing condition introduced in upload-artifact@v4.
Previously, we were updating every Layer ARN deployment output to the same artifact name. In V4, an explicit overwrite flag is required, which raises on race conditions (good behavior!).
Now, we upload every layer artifact with the region suffix, then merge all artifacts upon download. Everything else remains the same.
Changes
pattern
instead ofname
in download-artifact to be able to merge multiple artifactsUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.