-
Notifications
You must be signed in to change notification settings - Fork 421
chore(ci): remove aws-encryption-sdk from Lambda layer due to cffi being tied to python version #3853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): remove aws-encryption-sdk from Lambda layer due to cffi being tied to python version #3853
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3853 +/- ##
===========================================
+ Coverage 96.38% 96.42% +0.04%
===========================================
Files 214 214
Lines 10030 10102 +72
Branches 1846 1866 +20
===========================================
+ Hits 9667 9741 +74
+ Misses 259 258 -1
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. |
Issue number: #3852
Summary
Changes
We previously added the
aws-encryption-sdk
to our Lambda layer, but this caused issues since the SDK requires thecryptography
library be installed for each specific Python runtime version (3.8 to 3.12). To resolve this, we have removed the SDK from the Lambda layer for now.User experience
Users must install the
aws-encryption-sdk
and appropriate encryption library as dependencies in their projects based on their Python runtime until we find a way to provide version-specific layer builds.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.