-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event_sources): change partition and offset field types in KafkaEventRecord #4515
fix(event_sources): change partition and offset field types in KafkaEventRecord #4515
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4515 +/- ##
===========================================
+ Coverage 96.38% 96.43% +0.05%
===========================================
Files 214 219 +5
Lines 10030 10626 +596
Branches 1846 1976 +130
===========================================
+ Hits 9667 10247 +580
- Misses 259 267 +8
- Partials 104 112 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR so quickly @scampbell5!
APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #4504
Summary
Changes
Updated
offset
andpartition
properties to be anint
type instead ofstr
on theKafkaEventRecord
class.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.