Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(metrics): fix test references #5265

Merged
merged 1 commit into from
Sep 28, 2024
Merged

docs(metrics): fix test references #5265

merged 1 commit into from
Sep 28, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Sep 28, 2024

Issue number: #5266

Summary

PR #5160 moved the location of some of the test files. This PR adjusts sources to changes.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner September 28, 2024 07:42
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 28, 2024
Copy link

boring-cyborg bot commented Sep 28, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2024
Copy link

@leandrodamascena leandrodamascena linked an issue Sep 28, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emmanuel-ferdman, super nice catch! Thanks for fixing this, we completely missed that.

APPROVED!

@leandrodamascena leandrodamascena merged commit 5665d43 into aws-powertools:develop Sep 28, 2024
11 checks passed
Copy link

boring-cyborg bot commented Sep 28, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fix test references in Metrics utility
2 participants