Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add GovCloud layer info #5414

Merged
merged 3 commits into from
Oct 21, 2024
Merged

docs: Add GovCloud layer info #5414

merged 3 commits into from
Oct 21, 2024

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Oct 21, 2024

Issue number: #5385

Summary

Changes

Please provide a summary of what's being changed

Adds layer info for GovCloud regions

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner October 21, 2024 13:06
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@sthulb
Copy link
Contributor Author

sthulb commented Oct 21, 2024

Screenshot 2024-10-21 at 15 16 43

Example of how the docs look with this change

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wast thinking about to create a subsection named "GovCloud" and then add all the ARNs there.
image

The other change looks good to me.

WDYT?

@sthulb
Copy link
Contributor Author

sthulb commented Oct 21, 2024

I wast thinking about to create a subsection named "GovCloud" and then add all the ARNs there. image

The other change looks good to me.

WDYT?

I had the same idea as I made coffee about 5 min, I was about to give an example for that. My main issue is how the layer version number is incremented during release. I didn't want GovCloud to be skipped

@sthulb
Copy link
Contributor Author

sthulb commented Oct 21, 2024

Screenshot 2024-10-21 at 15 29 37

I think adding it as a new tab at the top probably works the best.

@leandrodamascena
Copy link
Contributor

I think adding it as a new tab at the top probably works the best.

I like both versions. Whichever one you want to keep works for me.

Copy link

@leandrodamascena
Copy link
Contributor

I had the same idea as I made coffee about 5 min, I was about to give an example for that. My main issue is how the layer version number is incremented during release. I didn't want GovCloud to be skipped

Yep, I thought about the same problem. But the idea is to trigger the GovCloud release right after the comercial release. So, we won't have this problem, in theory.

@leandrodamascena leandrodamascena self-requested a review October 21, 2024 13:50
@leandrodamascena leandrodamascena linked an issue Oct 21, 2024 that may be closed by this pull request
2 tasks
@sthulb sthulb merged commit 0f6f543 into develop Oct 21, 2024
4 checks passed
@sthulb sthulb deleted the docs/govcloud branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: GovCloud Docs
2 participants