Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): disable dry run in layer balancing workflow #5768

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Dec 19, 2024

Issue number: #5751

Summary

Changes

Please provide a summary of what's being changed

Fixes an issue with selecting dry-run in the balance script

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner December 19, 2024 11:13
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Dec 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 19, 2024
@leandrodamascena leandrodamascena linked an issue Dec 19, 2024 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena changed the title fix(ci): Dry run was accidentally enabled chore(ci): disable dry run in layer balancing workflow Dec 19, 2024
@github-actions github-actions bot removed the bug Something isn't working label Dec 19, 2024
@sthulb sthulb merged commit a5eca1e into develop Dec 19, 2024
4 checks passed
@github-actions github-actions bot added the internal Maintenance changes label Dec 19, 2024
@sthulb sthulb deleted the dry-run branch December 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Region build script
2 participants