Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event_source): Added missing properties in APIGatewayWebSocketEvent class #6411

Conversation

dave-dotnet-overall
Copy link
Contributor

@dave-dotnet-overall dave-dotnet-overall commented Apr 6, 2025

Issue number: #6409

Summary

Added missing properties for querystring parameters.

Changes

New properties added for query_string_parameters and multi_value_query_string_parameters.

User experience

def handler(event: APIGatewayWebSocketEvent):
    myParama = event.query_string_parameters["myParam"]

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dave-dotnet-overall dave-dotnet-overall requested a review from a team as a code owner April 6, 2025 06:39
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2025
Copy link

boring-cyborg bot commented Apr 6, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@leandrodamascena leandrodamascena changed the title fix(websocket event): Added 2 new properties for querystring parameters and multi value querystring parameters. fix(event_source): Added missing properties in APIGatewayWebSocketEvent class Apr 6, 2025
@leandrodamascena leandrodamascena linked an issue Apr 6, 2025 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena added the event_sources Event Source Data Class utility label Apr 6, 2025
@github-actions github-actions bot added the bug Something isn't working label Apr 6, 2025
Copy link
Contributor

github-actions bot commented Apr 6, 2025

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Apr 6, 2025
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Apr 6, 2025
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (aac0183) to head (6e649e0).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6411   +/-   ##
========================================
  Coverage    96.33%   96.33%           
========================================
  Files          243      243           
  Lines        11758    11764    +6     
  Branches       871      871           
========================================
+ Hits         11327    11333    +6     
  Misses         337      337           
  Partials        94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dave-dotnet-overall, thanks for sending this PR to fix this! Just a small change before we merge.

Can you please change this test to include these fields?

@boring-cyborg boring-cyborg bot added the tests label Apr 7, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
Copy link

sonarqubecloud bot commented Apr 7, 2025

@dave-dotnet-overall
Copy link
Contributor Author

Hey @dave-dotnet-overall, thanks for sending this PR to fix this! Just a small change before we merge.

Can you please change this test to include these fields?

Completed

@leandrodamascena leandrodamascena self-requested a review April 7, 2025 07:39
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dave-dotnet-overall! APPROVED!

@leandrodamascena leandrodamascena merged commit cc479b0 into aws-powertools:develop Apr 7, 2025
17 checks passed
Copy link

boring-cyborg bot commented Apr 7, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event_sources Event Source Data Class utility size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Missing Querystring values from WebSocket data classes
2 participants