-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event_source): Added missing properties in APIGatewayWebSocketEvent class #6411
fix(event_source): Added missing properties in APIGatewayWebSocketEvent class #6411
Conversation
…rystring parameters.
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6411 +/- ##
========================================
Coverage 96.33% 96.33%
========================================
Files 243 243
Lines 11758 11764 +6
Branches 871 871
========================================
+ Hits 11327 11333 +6
Misses 337 337
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dave-dotnet-overall, thanks for sending this PR to fix this! Just a small change before we merge.
Can you please change this test to include these fields?
|
Completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dave-dotnet-overall! APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #6409
Summary
Added missing properties for querystring parameters.
Changes
New properties added for
query_string_parameters
andmulti_value_query_string_parameters
.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.