fix(logger): fix exception on flush without buffer

[tonnico]

Issue number: #6793

Summary

Changes

Please provide a summary of what's being changed
earlier exit when no buffer config is set.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (a5482c8) to head (60e308a).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6794      +/-   ##
===========================================
+ Coverage    96.21%   96.23%   +0.01%     
===========================================
  Files          273      273              
  Lines        12691    12691              
  Branches       946      946              
===========================================
+ Hits         12211    12213       +2     
+ Misses         375      374       -1     
+ Partials       105      104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[leandrodamascena]

Hey @tonnico thanks for sending this PR. Your fork doesn't allow modification, so, can you please add this test to make sure we are testing this situation?

File: https://github.com/tonnico/powertools-lambda-python/blob/c2dd26f297cfcb8834cc0ecd96f256259a5acd9d/tests/functional/logger/required_dependencies/test_powertools_logger_buffer.py

def test_flush_buffer_without_buffer_config(stdout, service_name, lambda_context, monkeypatch):
    # Set initial trace ID for first Lambda invocation
    monkeypatch.setenv(constants.XRAY_TRACE_ID_ENV, "1-67c39786-5908a82a246fb67f3089263f")

    # GIVEN A logger without buffer configuration
    logger = Logger(level="DEBUG", service=service_name, stream=stdout)

    @logger.inject_lambda_context(flush_buffer_on_uncaught_error=True)
    def handler(event, context):
        # Log messages that should be flushed when an exception occurs
        logger.debug("this log line will be flushed after error - 1")
        logger.debug("this log line will be flushed after error - 2")
        raise ValueError("Test error")

    # WHEN Invoking the handler and expecting a ValueError
    # AND flush_buffer_on_uncaught_error is True but there is no logger buffer configuration
    with pytest.raises(ValueError):
        handler({}, lambda_context)

    # THEN Verify that buffered log messages are flushed without any exception
    log = capture_multiple_logging_statements_output(stdout)
    assert len(log) == 2, "Expected two log messages to be flushed"

[tonnico]

Hey @tonnico thanks for sending this PR. Your fork doesn't allow modification, so, can you please add this test to make sure we are testing this situation?

Hello @leandrodamascena. Thank you for the test. However, I have a slightly different view of the behaviour.

When no buffer configuration is set and the flush_buffer_on_uncaught_error parameter is set to True, nothing should be flushed because there is no buffer. Therefore, when the logger is set to DEBUG and a message is sent with logger.debug, I expect these messages to be sent immediately and not buffered.

I changed some comments and values and hope this is ok for you.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[leandrodamascena]

Hey @tonnico thanks for sending this PR. Your fork doesn't allow modification, so, can you please add this test to make sure we are testing this situation?

Hello @leandrodamascena. Thank you for the test. However, I have a slightly different view of the behaviour.

When no buffer configuration is set and the flush_buffer_on_uncaught_error parameter is set to True, nothing should be flushed because there is no buffer. Therefore, when the logger is set to DEBUG and a message is sent with logger.debug, I expect these messages to be sent immediately and not buffered.

I changed some comments and values and hope this is ok for you.

Thanks for fixing that, I agree 100% with you! Just let the CI completes and I'll merge!!

[leandrodamascena]

APPROVED!