fix(ci): update layer version for all AWS partitions in docs #7757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws-powertools#7650 This extends the fix from aws-powertools#6868 to handle all AWS partitions, not just commercial AWS. The previous fix only updated layer ARNs with specific python versions (e.g., python312) but missed the template placeholders with {python_version} for China and GovCloud partitions. Changes: - Updated hardcoded layer versions from :18 to :27 in docs/index.md - Extended update_layer_arn_v3.sh to handle AWS China (arn:aws-cn) and GovCloud (arn:aws-us-gov) layer ARNs - Added sed patterns for both specific versions and {python_version} placeholders across all AWS partitions The automation now correctly updates layer versions for: - Commercial AWS: arn:aws:lambda:{region}:017000801446:layer:... - AWS China: arn:aws-cn:lambda:cn-north-1:498634801083:layer:... - GovCloud East: arn:aws-us-gov:lambda:us-gov-east-1:165087284144:layer:... - GovCloud West: arn:aws-us-gov:lambda:us-gov-west-1:165093116878:layer:...
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
the
size/S
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7650
Summary
This extends the fix from #6868 to handle all AWS partitions, not just commercial AWS. The previous fix only updated layer ARNs with specific python versions (e.g.,
python312) but missed the template placeholders with{python_version}for China and GovCloud partitions.Changes
Updated
docs/index.md: Changed hardcoded layer versions from:18to:27for all AWS partitions (8 ARN updates total)Enhanced
layer_v3/scripts/update_layer_arn_v3.sh: Added automation to update China and GovCloud layer ARNsarn:aws-cn:lambda(AWS China)arn:aws-us-gov:lambda(GovCloud)python312) and template placeholders ({python_version})User experience
Before:
:18in documentationAfter:
:27By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.