-
Notifications
You must be signed in to change notification settings - Fork 421
feat(parameters): Allow callable transforms #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters): Allow callable transforms #894
Conversation
…d start thinking about what to do here.
I'm not that having a parameter as both str and callable is the best approach. maybe have it is as string, set to custom and add another param for the callable? |
I don't like it either but I am working within a compatible solution. Ideally transform would be an instance of a transform object with a .transform method and a list of compatible key suffixes. Error handling is the same as the json and binary methods. all exceptions lead to None unless transform errors are set to raise. |
perhaps the best approach is to register transform classes by string an key suffix and then do a lookup and execute them generically. |
@whardier we appreciate the bias for action in implementing a feature you need, however, we'd like to hear from more customers that this is necessary & requirements before diving into the implementation where we can iron out maintainability, etc. Locking this PR for now until we hear from more customers |
Issue #, if available:
#893
Description of changes:
Add in changes to base parameter classes and feature flags appconfig store to allow for callable transforms to be used as well as the available stringy references.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.