-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parameter utility #96
feat: add parameter utility #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a python pro here but learning :) Looks neat 💯 . Looks like few build steps are failing.
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
- Coverage 100.00% 98.99% -1.01%
===========================================
Files 17 24 +7
Lines 467 698 +231
Branches 42 64 +22
===========================================
+ Hits 467 691 +224
- Misses 0 7 +7
Continue to review full report at Codecov.
|
OK, this should work better. I've used monkeypatch to inject the environment variables instead. 😅 |
…powertools-python into parameter-utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some initial comments and thoughts - It looks great and super flexible!
I'll continue reviewing the other bits later today
Reviewing the docs now - Thanks for implementing the other changes so quickly @nmoutschen ;) Can't wait for 3.6 to reach EOL, so we can use the new Protocols more effectively instead of all-in on ABC: https://www.python.org/dev/peps/pep-0544/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Made some suggestions on how to make it easier for beginners, suggestions on search/parsing, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! A few minor changes to complete and we should merge this
Merge both high level and class provider functions and methods, since they require the same IAM permission.
SHIP IT! |
* develop: chore: version bump to 1.3.1 fix(capture_method): should yield inside with (#124) chore: bump version to 1.3.0 (#122) chore(deps): bump prismjs from 1.20.0 to 1.21.0 in /docs chore(deps): bump elliptic from 6.5.2 to 6.5.3 in /docs feat: add parameter utility (#96) chore: bump version to 1.2.0 (#119) feat: add support for tracing of generators using capture_method decorator (#113)
Issue #, if available: #94
Description of changes:
Add a new module
aws_lambda_powertools.utilities
with a first utility functionget_parameter
to retrieve and cache SSM parameter values.Checklist
Breaking change checklist
RFC issue #: #94
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.