-
Notifications
You must be signed in to change notification settings - Fork 462
feat(event-handler): new resolvers to fix current_event typing #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ties Add new specialized resolvers APIGatewayProxyEventResolver, APIGatewayProxyEventV2Resolver and ALBEventResolver closes aws-powertools#761
Codecov Report
@@ Coverage Diff @@
## develop #978 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5335 5347 +12
Branches 607 610 +3
========================================
+ Hits 5333 5345 +12
Partials 2 2
Continue to review full report at Codecov.
|
current_event doesn't show all properties
heitorlessa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to make names shorter, explicit, and remove the Event redundant part. Also to remove duplicate docstrings as it's inherited from super class (despite the proxy_type showing in VSCode) to prevent what happened to Parameters utilities docstrings being accidentally left behind too
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
…a-powertools-python into fix-event-handler * 'fix-event-handler' of https://github.com/gyft/aws-lambda-powertools-python: docs(event_handler): Rename ApiGatewayResolver to APIGatewayRestResolver chore: correct docs chore: correct docs chore: use isinstance over type docs: add better BDD coments fix(logger): test generates logfile
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Issue #, if available:
closes #761
Description of changes:
Add new specialized resolvers
APIGatewayRestResolver,APIGatewayHttpResolverandALBResolverExample of an Application Load Balancer handler (ALBResolver) where
current_eventcan only be anALBEventExample of an REST API handler (APIGatewayRestResolver) where
current_eventcan only be anAPIGatewayProxyEventExample of an Http API handler (APIGatewayHttpResolver) where
current_eventcan only be anAPIGatewayProxyEventV2Works with VSCode and PyCharm:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.