Skip to content

Feature request: validator Middy.js middleware for JSON Schema validation #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Feb 16, 2025 · 3 comments · Fixed by #3694
Closed
1 of 2 tasks

Feature request: validator Middy.js middleware for JSON Schema validation #3609

dreamorosi opened this issue Feb 16, 2025 · 3 comments · Fixed by #3694
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility validation This item relates to the Validation Utility

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Feb 16, 2025

Use case

To continue the implementation of the Validation utility started in #3607, we should implement a validator Middy.js middleware that can be used by customers who are already invested in Middy.js to wrap a function handler and validate both inputs and outputs against a set of JSON Schemas.

Solution/User Experience

The middleware will use the validate function implemented in #3607 under the hood, and as such it should accept similar parameters to that function, albeit with some changes to accommodate the fact that 1/ it's a middleware, and 2/ it can validate both input and outputs of the decorated method.

The middleware will take a single params object that has the following items:

  • an optional inboundSchema - this is the JSON Schema used to validate the incoming payload
  • an optional outboundSchema - this is the JSON Schema used to validate the response payload
  • an optional envelope parameter of type string (more on this later)
  • an optional formats optional parameter to pass custom formats
  • an optional externalRefs array of schemas that can be used to supply external references to the main schema
  • an optional ajv parameter that customers can use to provide their own instance - this is useful when wanting to use a different JSON Schema version/draft

Both inboundSchema and outboundSchema are optional, this is intentional because we want to allow customers to validate one, the other, or both. When one of them is provided, the corresponding onBefore and onAfter hooks in the middleware will be no-ops.

In terms of implementation, the validator decorator will set two Middy.js hooks:

  • onBefore: if inboundSchema is present, call the validate function using the schema as schema and the first argument of the decorated method as payload, as well as all the other optional params to validate the incoming payload. Replace the event with the result of the validate function call
  • onAfter: if outboundSchema is present, call the validate function using the schema as schema and the response of the handler as payload, as well as all the other optional params except for envelope to validate it

I'm unsure if it's even possible, but if it is, the middleware should be a generic function and accept types for both the event and response, and set these types on the handler - as I mentioned, I am unsure if this is doable. If not, or too time consuming, feel free to skip it for now and prioritize the overall implementation.

As part of the implementation the implementer should also write unit tests to cover 100% of the files, lines, branches of the code added as part of this issue. All the dependencies needed should already be present in the workspace, ideally the implementation should follow existing project conventions as much as possible. The middleware should be in its own file, i.e. packages/validation/src/middleware.ts.

When it comes to references, you can find an example of how this middleware would be used in the docs/utilities/validation.md file.

If instead you're unfamiliar with how to implement Middy.js middlewares, I've added an example below

const validator = (params: ValidatorOptions) => {
  const before = async (request) => {
    // if no inbound schema is not present, return undefined here
    // validate inbound schema here
    // replace request.event with the result of the validate call
  }
  
  const after = async (request) => {
    // if no inbound schema is not present, return undefined here
    // validate outbound schema here
  }
  
  return {
    before,
    after,
  }
}

Additionally, you can also refer to the Middy.js guide on how to write middlewares.

Alternative solutions

N/A

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility on-hold This item is on-hold and will be revisited in the future validation This item relates to the Validation Utility labels Feb 16, 2025
@dreamorosi dreamorosi added this to the Validation utility milestone Feb 16, 2025
@dreamorosi dreamorosi moved this from Triage to On hold in Powertools for AWS Lambda (TypeScript) Feb 16, 2025
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation help-wanted We would really appreciate some support from community for this one and removed on-hold This item is on-hold and will be revisited in the future labels Feb 27, 2025
@dreamorosi dreamorosi moved this from On hold to Backlog in Powertools for AWS Lambda (TypeScript) Feb 27, 2025
@VatsalGoel3
Copy link
Contributor

Would take up this issue in continuation of #3608

Copy link
Contributor

github-actions bot commented Mar 5, 2025

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added pending-release This item has been merged and will be released soon and removed help-wanted We would really appreciate some support from community for this one confirmed The scope is clear, ready for implementation labels Mar 5, 2025
@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Mar 7, 2025
@aws-powertools aws-powertools deleted a comment from github-actions bot Mar 7, 2025
@dreamorosi dreamorosi added pending-release This item has been merged and will be released soon and removed completed This item is complete and has been merged/shipped labels Mar 7, 2025
Copy link
Contributor

This is now released under v2.17.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Mar 25, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility validation This item relates to the Validation Utility
Projects
2 participants