-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: reduce npm_modules size #419
Comments
Thanks @michaelbrewer for the heads-up! |
of coz we should see what size the packaged lambda is and how small we can make it. |
Good point, we initially removed the whole |
|
@saragerion there is also a lot of test resources in "commons" that we already have in shared. About 208k worth. |
|
I know this issue closed, but i assume for the production release there is plans to see how to minimize the size of the node_modules? Like how the aws-sdk-v3 is very lightweight: https://aws.amazon.com/blogs/developer/how-we-halved-the-publish-size-of-modular-aws-sdk-for-javascript-clients/ And for non-typescript users? should @types/aws-lambda always be included? And maybe tips for the lambda layer: |
Bug description
The current bundle size of the Logger library is unnecessarily big. This has an impact on the performance of the Lambda functions (cold starts included).
Expected Behavior
The node_modules folder has a reasonable size.
Current Behavior
The node_modules folder is 139M.
Possible Solution
One of the biggest reasons is the lodash library that is currently a prod dependency, which is unnecessary.
It would also be good to double check whether we publish the NPM packages installing only the prod dependencies and not the dev dependencies.
Steps to Reproduce
Install the library in your local env, and check the node_modules folder size:
Environment
Related issues, RFCs
N/A
The text was updated successfully, but these errors were encountered: