Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): migrate init script and husky to v9 #2131

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 23, 2024

Description of your changes

image

husky install is deprecated starting from version 9.0 More info here
We run this command on the init-environment script and we get the deprecation message above.

  • Updated the script in package.json to husky
  • Updated pre-commit and pre-push hooks to match the v9 syntax

Related issues, RFCs

Issue number: #2130

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@hjgraca hjgraca requested a review from a team February 23, 2024 12:37
@hjgraca hjgraca requested a review from a team as a code owner February 23, 2024 12:37
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Feb 23, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Feb 23, 2024
@dreamorosi dreamorosi linked an issue Feb 23, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting this, as discussed on Slack we're going to wait for #2117 to be merged before merging any non-security related PR.

@dreamorosi dreamorosi added the do-not-merge This item should not be merged label Feb 23, 2024
remove init-environment script, move husky to setup-local
@pull-request-size pull-request-size bot added size/XS PR between 0-9 LOC and removed size/S PR between 10-29 LOC labels Feb 23, 2024
@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Feb 28, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
8.4% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 3acfb68 into aws-powertools:main Feb 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Migrate to husky v9 syntax to remove deprecation warning
2 participants