Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): migrate batch utility to biome #2804

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR migrates the linting and formatting of the Batch Processing utility to use Biome instead of a combination of Eslint and Prettier.

As part of the PR I had to fix a few inconsistencies that came up.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2794


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 22, 2024
@dreamorosi dreamorosi requested review from a team as code owners July 22, 2024 14:23
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels Jul 22, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 22, 2024
@dreamorosi
Copy link
Contributor Author

Review & merge this after #2791.

@dreamorosi dreamorosi added the on-hold This item is on-hold and will be revisited in the future label Jul 22, 2024
@dreamorosi dreamorosi removed documentation Improvements or additions to documentation dependencies Changes that touch dependencies, e.g. Dependabot, etc. on-hold This item is on-hold and will be revisited in the future labels Jul 22, 2024
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jul 22, 2024
Copy link

@dreamorosi dreamorosi merged commit b9db070 into main Jul 22, 2024
12 checks passed
@dreamorosi dreamorosi deleted the chore/biome_batch branch July 22, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add biome to project (batch)
2 participants