-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(layers): add Parser to layer #3101
chore(layers): add Parser to layer #3101
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
This is my first PR against this project, so please let me know if I am missing anything here. Also, could someone please confirm that the changes from this PR will trigger a new layer to be built, and following this the documentation will be updated automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @scratchclaggy, thank you for the PR.
The utility doesn't come with Zod by default, so we need to install it.
You should add it to the block around line 110.
Hey @scratchclaggy, can you also add the package to our e2e tests. We usually check if the package is present and can be imported. While we invoke some of the utilities in our canary lambda directly, i.e. logger and metrics. I think we can also run a parse small parse command with a fairly trivial payload, just to be sure that it's safe. |
191e08b
to
decd13e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding the tests!
Quality Gate passedIssues Measures |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Summary
Small PR to add the new parser feature to the published lambda layers.
Changes
Adds the feature to the layer stacks in the layer package.
Issue number: #3100
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.