Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layers): add Parser to layer #3101

Merged

Conversation

scratchclaggy
Copy link
Contributor

Summary

Small PR to add the new parser feature to the published lambda layers.

Changes

Please provide a summary of what's being changed

Adds the feature to the layer stacks in the layer package.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3100


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@scratchclaggy scratchclaggy requested review from a team as code owners September 22, 2024 13:11
@boring-cyborg boring-cyborg bot added the layers Items related to the Lambda Layers pipeline label Sep 22, 2024
Copy link

boring-cyborg bot commented Sep 22, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 22, 2024
@scratchclaggy
Copy link
Contributor Author

This is my first PR against this project, so please let me know if I am missing anything here.

Also, could someone please confirm that the changes from this PR will trigger a new layer to be built, and following this the documentation will be updated automatically.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scratchclaggy, thank you for the PR.

The utility doesn't come with Zod by default, so we need to install it.

You should add it to the block around line 110.

@dreamorosi dreamorosi linked an issue Sep 22, 2024 that may be closed by this pull request
2 tasks
@am29d
Copy link
Contributor

am29d commented Sep 24, 2024

Hey @scratchclaggy, can you also add the package to our e2e tests. We usually check if the package is present and can be imported.

While we invoke some of the utilities in our canary lambda directly, i.e. logger and metrics. I think we can also run a parse small parse command with a fairly trivial payload, just to be sure that it's safe.

@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Sep 24, 2024
@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/XS PR between 0-9 LOC labels Sep 24, 2024
@scratchclaggy scratchclaggy force-pushed the chore(layers)/add-parser-to-layer branch from 191e08b to decd13e Compare September 24, 2024 14:07
@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/S PR between 10-29 LOC labels Sep 24, 2024
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the tests!

Copy link

@dreamorosi dreamorosi merged commit cc3b4d3 into aws-powertools:main Sep 25, 2024
15 checks passed
Copy link

boring-cyborg bot commented Sep 25, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layers Items related to the Lambda Layers pipeline size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: include parser feature in lambda layer
3 participants