test(idempotency): migrate to vitest #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
automation
pull-request-size
bot
added
the
size/XL
…owertools-lambda-typescript into test/idempotency_vitest
pull-request-size
bot
added
size/XXL
leandrodamascena
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Hey @dreamorosi! I see that you basically moved things from jest to vitest and reorganized files. If CI is green I'm good with this PR.
I just left a comment to check if the comment was intentional or not.
APPROVED!
dreamorosi
dismissed stale reviews from leandrodamascena and am29d
via
a77fe06
|
|
Sorry, I had to make another commit to remove a leftover test I had left commented out. @am29d, @leandrodamascena, if you could click approve again please. |
leandrodamascena
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the unit tests for the Idempoency package so that they use vitest instead of Jest.
The e2e tests for the utility will be addressed in a future PR. I also removed a number of test cases that were redundant while leaving coverage unaffected. There's still room for further improvement but I decided to not address it now for the sake of keeping the PR focused.
Issue number: closes #3123
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.