fix(parser): event type literal for selfManagedKafka #3325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug for event type literal for self managed kafka events.
Changes
Beside the literal change I had to remove
--changed
flag, as it prevented me from push due to wrong coverage. When running the pre-push tests the coverage for unrelated files which were not affected by the changes were reporting low coverage. In my case it was SQS envelope, which has nothing to do with the kafka schema changes.I like the idea of running only change related files to save time, it was always bothering me. I looked into vites config and probed few solutions but with no results. We should add the flag at some point once we figured out what is causing the wrong coverage.
Issue number: closes #3324
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.