Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add advanced automation #3438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ci): Add advanced automation #3438

wants to merge 1 commit into from

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Dec 20, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR adds the ability to bootstrap new regions and create SSM parameters to alias Lambda Layer ARNs.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3200, #3439


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested review from a team as code owners December 20, 2024 13:27
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Dec 20, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Dec 20, 2024
@github-actions github-actions bot added feature PRs that introduce new features or minor changes labels Dec 20, 2024
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

Copy link
Contributor

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template here: https://github.com/aws-powertools/powertools-lambda-typescript/blob/develop/.github/PULL_REQUEST_TEMPLATE.md#acknowledgment

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Dec 20, 2024
name: Install CDK
working-directory: build
run: |
npm i aws-cdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the version we already have installed in the workspace to avoid inconsistency issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately didn't do it since I didn't want to get into a situation where we're always running a old version by accident

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather run an older version that we know works both because of e2e tests and release process, than a new one that might be broken when running this specific workflow.

Regardless, not pinning any version and pulling from the remote is not a great idea. If we're gonna pin it here, we might as well use the one defined in the lock file, so Dependabot updates it once a week

mask-aws-account-id: true
- id: go-setup
name: Setup Go
uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin a Go version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot will update this, no? I don't know if we need to worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation do-not-merge This item should not be merged feature PRs that introduce new features or minor changes need-issue This PR needs an issue before it can be reviewed/worked on further size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants