test: fix transient fails in log sampling tests #3736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here are 2 consecutive runs where the tests are passing at the first try, after the fix: |
dreamorosi
changed the title
dreamorosi
requested review from
leandrodamascena
and removed request for
am29d
leandrodamascena
approved these changes
Mar 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the e2e test for Logger, related to log sampling, to account for the new mechanism introduced in #3278. The test was using the decorator - which now refreshes the sampling calculation at each request - but was also calling the refresh method manually, which caused double sampling in some cases and causing the test to fail.
As a side quest, I also slightly improved the logs for the e2e tests. In #3665 we adopted a new CLI toolkit and back then I silenced most of the logs except when running in debug mode. Over time I realized that I'd have preferred to have some indication that the stacks were being created/destroyed, so I improved the logs to do that. Now they look like this:
Enabling debug mode when re-running still prints out everything.
Issue number: closes #3735
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.