Skip to content

docs(idempotency): add idempotency doc for CachePersistenceLayer #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

arnabrahman
Copy link
Contributor

@arnabrahman arnabrahman commented May 17, 2025

Summary

CachePersistenceLayer docs have been added to idempotency.

Changes

  • Followed the Python documentation format for CachePersistenceLayer.
  • I moved the Persistence Layer section out of the Advanced section; it was probably a mistake. This aligns with the Python documentation structure.
  • Updated the Node.js version for the documentation Docker image to fix local build issues.

One thing I couldn't make it work is the sub-sections. For example, Python doc has subsections of Redis (https://docs.powertools.aws.dev/lambda/python/latest/utilities/idempotency/#redis-database). I am not sure what I am missing here.

Issue number: #3914


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation idempotency This item relates to the Idempotency Utility labels May 17, 2025
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label May 17, 2025
@arnabrahman arnabrahman marked this pull request as ready for review May 17, 2025 05:00
@dreamorosi dreamorosi changed the title doc(idempotency): add idempotency doc for CachePersistenceLayer docs(idempotency): add idempotency doc for CachePersistenceLayer May 17, 2025
@dreamorosi
Copy link
Contributor

Hi @arnabrahman, thank you for the PR! I'll review it later today/tomorrow morning max

@dreamorosi
Copy link
Contributor

I have started reviewing the PR and I wanted to rearrange a couple sections here & there, but I need a bit more time. I'll continue later today.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation idempotency This item relates to the Idempotency Utility size/XL PRs between 500-999 LOC, often PRs that grown with feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants