-
Notifications
You must be signed in to change notification settings - Fork 163
feat(event-handler): add base router class #3972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ea7f951
to
7366df9
Compare
I've updated this PR with mkst of the changes that were in scope in #3971:
Note the two requirements not implemented, is there something I'm missing here that would let me ship them in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @svozza, great PR! I won't be reviewing specifics about TS, but I left two comments about the expected experience we want to have in this utility.
You're right, this should've been in either #4139 or #4140
That's correct, nothing more to do here - it was phrased awkwardly. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions for the tests, they should also remove the Sonar findings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my feedback @svozza!
Thank you both - as discussed offline, we'll merge the PR after tomorrow's release. |
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
a0bf0ea
to
730dfc5
Compare
|
Summary
Changes
Issue number: closes #3971
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.