Skip to content

Conversation

@flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 5, 2022

Description of your changes

Make npm packages public

Related issues, RFCs

#372

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added all internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jan 5, 2022
@dreamorosi dreamorosi added this to the beta-release milestone Jan 5, 2022
@flochaz flochaz mentioned this pull request Jan 5, 2022
23 tasks
@dreamorosi dreamorosi self-requested a review January 5, 2022 15:24
@flochaz flochaz merged commit f6e5836 into main Jan 5, 2022
@flochaz flochaz deleted the chore/all/publicNpm branch January 5, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants