Skip to content

Conversation

shrivarshapoojari
Copy link
Contributor

@shrivarshapoojari shrivarshapoojari commented Sep 23, 2025

Summary

Changes

This PR adds registry-url: 'https://registry.npmjs.org' parameter to the actions/setup-node steps in:

.github/workflows/make-release.yml
.github/workflows/publish-package.yml

Issue number: closes #4538


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Sep 23, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 23, 2025
@shrivarshapoojari shrivarshapoojari changed the title chore: Add registry-url to setup-node steps to fix Scorecard packaging check chore: add registry-url to setup-node steps to fix Scorecard packaging check Sep 23, 2025
@sdangol sdangol changed the title chore: add registry-url to setup-node steps to fix Scorecard packaging check chore(ci): add registry-url to setup-node steps to fix Scorecard packaging check Sep 23, 2025
@sdangol
Copy link
Contributor

sdangol commented Sep 23, 2025

While we're at it, let's also update the OSSF Scorecard badge url in the main README file to use this link: https://scorecard.dev/viewer/?uri=github.com/aws-powertools/powertools-lambda-typescript

Right now it uses a JSON link that it's pretty hard to parse, but this rendered one is better.

@shrivarshapoojari Could you also update this scorecard badge url mentioned as in the issue description while you're at it

@sdangol sdangol changed the title chore(ci): add registry-url to setup-node steps to fix Scorecard packaging check chore(ci): add registry-url to setup-node steps to fix Scorecard packaging check Sep 23, 2025
@shrivarshapoojari
Copy link
Contributor Author

shrivarshapoojari commented Sep 23, 2025

Sure!

@shrivarshapoojari Could you also update this scorecard badge url mentioned as in the issue description while you're at it

Copy link

@shrivarshapoojari
Copy link
Contributor Author

Hi @sdangol I have update the OpenSSF uri.
Please review the changes and let me know further changes required.
Thanks

@sdangol sdangol changed the title chore(ci): add registry-url to setup-node steps to fix Scorecard packaging check chore(ci): add registry-url to setup-node steps to fix Scorecard packaging check Sep 23, 2025
@sdangol sdangol merged commit fd156aa into aws-powertools:main Sep 23, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Add registry-url to setup-node steps to fix Scorecard packaging check
2 participants