Skip to content

build(all): use es2019 target to support on Node12 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 1, 2022
Merged

build(all): use es2019 target to support on Node12 #925

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
21924c8
fix(all): replicate issue on node 12
ijemmy May 25, 2022
2e7cbdd
build: switch to nodejs 12
ijemmy May 26, 2022
9749434
build: force type on descriptor to make apply metho not optional
ijemmy May 30, 2022
146150c
TMP: figuring out why all ?. are broken
ijemmy May 30, 2022
1ed2ea5
build: fix missing branch coverage in logger
ijemmy May 30, 2022
0ed4111
build: fix all tracer branch coverage issue except segment undefined
ijemmy May 30, 2022
9535fca
build: fix branch coverage (confirmed that subsegment cannot be undef…
ijemmy May 31, 2022
cc85530
build: fix linting
ijemmy May 31, 2022
3f193c8
build: Fix linting and missing branch coverage
ijemmy May 31, 2022
3cbd390
build(logger): switch to use uuid.v4 instead of randomUUID()
ijemmy May 31, 2022
037146e
build: change workflow to run on all packages
ijemmy May 31, 2022
817c5a0
build: run on unit tests in all NodeJS environment
ijemmy May 31, 2022
5ff8739
build: remove all randomUUID as it breaks in NodeJS12
ijemmy May 31, 2022
7a23545
build: remove unused file
ijemmy May 31, 2022
cbb478a
chore(tracer): remove debug statements
ijemmy May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/pr_lint_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ jobs:
runs-on: ubuntu-latest
env:
NODE_ENV: dev
strategy:
matrix:
version: [12, 14, 16]
fail-fast: false
steps:
- uses: actions/checkout@v3
- name: "Use NodeJS 16"
- name: "Use NodeJS"
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: ${{ matrix.version }}
- name: Install npm@8.x
Comment on lines +10 to 20
Copy link
Contributor Author

@ijemmy ijemmy May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unit tests fail in NodeJS12, so I make use of matrix strategy here to make sure that we don't introduce any issue later.

run: npm i -g npm@next-8
- name: "Setup npm"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/run-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@ jobs:
matrix:
package: [logger, metrics, tracer]
version: [12, 14, 16]
fail-fast: false
steps:
- name: "Checkout"
uses: actions/checkout@v3
- name: "Use NodeJS 16"
- name: "Use NodeJS"
uses: actions/setup-node@v3
with:
node-version: 16
node-version: ${{ matrix.version }}
- name: "Install npm@8.x"
run: npm i -g npm@next-8
- name: "Install monorepo packages"
Expand Down
4 changes: 2 additions & 2 deletions examples/cdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"outDir": "lib",
Expand All @@ -22,7 +22,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"jest",
"node"
Expand Down
4 changes: 2 additions & 2 deletions examples/lambda-functions/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
Expand All @@ -21,7 +21,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"node"
]
Expand Down
4 changes: 2 additions & 2 deletions examples/sam/src/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
Expand All @@ -21,7 +21,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"node"
]
Expand Down
4 changes: 2 additions & 2 deletions examples/sam/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
Expand All @@ -21,7 +21,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"node"
]
Expand Down
117 changes: 74 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"@types/aws-lambda": "^8.10.72",
"@types/jest": "^27.4.0",
"@types/node": "^17.0.8",
"@types/uuid": "^8.3.4",
"@typescript-eslint/eslint-plugin": "^5.12.1",
"@typescript-eslint/parser": "^5.12.1",
"archiver": "^5.3.0",
Expand All @@ -78,7 +79,8 @@
"ts-node": "^10.0.0",
"typedoc": "^0.22.11",
"typedoc-plugin-missing-exports": "^0.22.6",
"typescript": "^4.1.3"
"typescript": "^4.1.3",
"uuid": "^8.3.2"
},
"files": [
"lib/**/*"
Expand Down
4 changes: 2 additions & 2 deletions packages/commons/tsconfig-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
Expand All @@ -23,7 +23,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"jest",
"node"
Expand Down
4 changes: 2 additions & 2 deletions packages/commons/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
"target": "ES2019",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
Expand All @@ -23,7 +23,7 @@
"watchDirectory": "useFsEvents",
"fallbackPolling": "dynamicPriority"
},
"lib": [ "es2020" ],
"lib": [ "es2019" ],
"types": [
"jest",
"node"
Expand Down
Loading