Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interfaces and their implementations for QoS features - Tests #6

Merged
merged 5 commits into from
Apr 9, 2019
Merged

New interfaces and their implementations for QoS features - Tests #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b21f945
Merge pull request #4 from aws-robotics/qos-test
ross-desmond Apr 3, 2019
9698651
Add tests for unsupported qos checks on initialize
ross-desmond Apr 2, 2019
8ee405d
Use std::chrono instead of manual conversions
ross-desmond Apr 3, 2019
cffefab
Reformat spacing event.c
ross-desmond Apr 3, 2019
9cd4028
Reformat subscription event init return event.c
ross-desmond Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions rcl/src/rcl/event.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ rcl_publisher_event_init(
return RCL_RET_INVALID_ARGUMENT;
}

return rmw_publisher_event_init(&event->impl->rmw_handle,
publisher->impl->rmw_handle, rmw_event_type);
return rmw_publisher_event_init(
&event->impl->rmw_handle,
publisher->impl->rmw_handle,
rmw_event_type);
}

rcl_ret_t
Expand Down Expand Up @@ -120,8 +122,10 @@ rcl_subscription_event_init(
return RCL_RET_INVALID_ARGUMENT;
}

return rmw_subscription_event_init(&event->impl->rmw_handle,
subscription->impl->rmw_handle, rmw_event_type);
return rmw_subscription_event_init(
&event->impl->rmw_handle,
subscription->impl->rmw_handle,
rmw_event_type);
}

rcl_ret_t
Expand Down
2 changes: 1 addition & 1 deletion rcl/test/rcl/test_count_matched.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ TEST_F(CLASSNAME(TestCountFixture, RMW_IMPLEMENTATION),

rcl_publisher_t pub = rcl_get_zero_initialized_publisher();

rcl_publisher_options_t pub_ops;
rcl_publisher_options_t pub_ops = rcl_publisher_get_default_options();
pub_ops.qos.history = RMW_QOS_POLICY_HISTORY_KEEP_LAST;
pub_ops.qos.depth = 10;
pub_ops.qos.reliability = RMW_QOS_POLICY_RELIABILITY_BEST_EFFORT;
Expand Down
Loading