Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add Explore sample app #135

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

imraymondlee
Copy link
Contributor

Adding a sample app that provides similar maps, places, and routes functionalities to the Explore app in the Amazon Location Service Console.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi
Copy link
Member

Hi @imraymondlee thanks for the new sample, looking forward to reviewing this early next week (likely on Monday 2nd).

Question: would you be open on including an amplify folder to create & deploy all the required resources with amplify init & amplify deploy? This would be in addition to the manual instructions that you have already included, it would just provide a quick alternative for those users who are into Amplify CLI.

If you like the idea you could reuse the amplify directory from this other sample. If instead this is part of a different content strategy and the instructions must stay as they are disregard the question.

@imraymondlee
Copy link
Contributor Author

That's a good suggestion, I will need to discuss with the team about that.

Add max zoom to the map.
Limit coordinates to 6 decimal positions.
Fix Places markers positioning.
Display departure and destination position in Routes panel.
@imraymondlee
Copy link
Contributor Author

Spoke with the team, and we have decided that we will not be adding the Amplify CLI support at the moment. I have also received some additional feedback and pushed a commit for those changes.

@dreamorosi
Copy link
Member

dreamorosi commented May 2, 2022

Overall the demo looks good.

I found the Place Index & Routing features a bit disconnected though. For instance if I search a place using the geocoder component, and then click "routes" I would kind of expect the marker I just placed to be used in the route. Instead what happens is that the black marker stays there, and I have to select again start & destination points for my route:
image

If the above is too much work, at least make the black mark disappear & reset the geocoder state so that you don't have two completely separate things on the map I'm looking at.

Fix Routes button SVG not visible.
Highlight step for plotting departure and destination position.
Update README.
Update styles.
@imraymondlee imraymondlee requested a review from dreamorosi May 2, 2022 23:42
@dreamorosi dreamorosi merged commit 1393977 into aws-samples:main May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants