Loosen XlsxWriter version constraints #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog for XlsxWriter suggests 3.1.0 is a minor change (not breaking from <3.1).
Belval
approved these changes
Jan 11, 2024
|
Thank you for your contribution, this change will be added to the v1.7.0 release that should be live early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In attempting to use this project as a dependency, I noticed it specifies an older version constraint for
XlsxWriter(<3.1) which conflicts with my project's requirements. In investigating theXlsxWriterrelease notes, it appears that 3.1 is just a minor release (no obvious breaking changes) so I think we can loosen the constraints here.I ran the test suite locally with the latest version of
XlsxWriter(3.1.9) and all the tests passed (which I put at least some stock in because I see.to_excel()calls in the test suite, which I know are being called).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.