add a new cdk example that allow us to use ipam pool id in a L2 vpc construct (ec2.vpc) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2022 12:39
…onstruct (ec2.vpc) solving the issue : no parameter for ipam pool id in ec2.vpc
2 tasks
indrora
suggested changes
Jun 29, 2023
| cidr_range = cidr_range, | ||
| region_cidr_range = region_cidr_range, | ||
| env=cdk.Environment( | ||
| account=os.environ["CDK_DEFAULT_ACCOUNT"], |
There was a problem hiding this comment.
This will result in a KeyError if this environment variable is not set.
Handle this better: os.getenv(k, default) does not throw an exception and provides a default value.
|
|
||
| The deployement provides a VPC with 2 subnets ( private and public ) on each availability zone ( you could customize your VPC by modifying the vpc_stack.py code ) | ||
| The Ipam_stack have a cidr_range for the top level ipam pool as "11.0.0.0/8" and "11.0.0.0/12" for the region ipam pool you can modify the two variable in app.py | ||
|
|
There was a problem hiding this comment.
Tell the user what the value of this is. Tell the user what they should be able to see/do with this. how can the customer see the two VPCs in each AZ?.
Comment on lines
+4
to
+7
| This is cdk example project for CDK development with Python. | ||
|
|
||
| The project provides a solution that I already suggested for the issues reported from aws-cdk issues about using IPAM pool id in the ec2.vpc L2 construct : | ||
| https://github.com/aws/aws-cdk/issues/21333 |
There was a problem hiding this comment.
Suggested change
| This is cdk example project for CDK development with Python. | |
| The project provides a solution that I already suggested for the issues reported from aws-cdk issues about using IPAM pool id in the ec2.vpc L2 construct : | |
| https://github.com/aws/aws-cdk/issues/21333 | |
| This project demonstrates using IPAM pool in Amazon EC2 VPCs. |
|
This PR is so old that if it doesn't easily get resolved in the next few weeks I'm likely to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-cdk#21333
Fixes #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.