feat(galileo-cli): document upload external module switch to async load

aws-samples · Nov 1, 2023 · 44940db · 44940db
1 parent f0d51a3
commit 44940db
Show file tree

Hide file tree

Showing 6 changed files with 97 additions and 107 deletions.
diff --git a/demo/corpus/embeddings/poetry.lock b/demo/corpus/embeddings/poetry.lock
diff --git a/packages/galileo-cli/examples/README.md b/packages/galileo-cli/examples/README.md
@@ -80,7 +80,7 @@ In your script, you need to import `DocumentMetadata` and `IMetadataProvider` fr
 import { DocumentMetadata, IMetadataProvider } from "../../src"; // or, later: ... from "@aws-galileo/cli"
 
 export class MetadataProvider implements IMetadataProvider {
-  getMetadata(): string | DocumentMetadata {
+  async getMetadata(): Promise<string | DocumentMetadata> {
 
     // option 1:
     const metadataFile: string = ...

diff --git a/packages/galileo-cli/examples/csv-loader/metadata-provider-object.ts b/packages/galileo-cli/examples/csv-loader/metadata-provider-object.ts
@@ -5,7 +5,7 @@ import { parseCsv } from "./parser-common";
 import { DocumentMetadata, IMetadataProvider } from "../../src";
 
 export class MetadataProvider implements IMetadataProvider {
-  getMetadata(): string | DocumentMetadata {
+  async getMetadata(): Promise<string | DocumentMetadata> {
     // build the metadata
     const docMetadata = parseCsv();
 

diff --git a/packages/galileo-cli/examples/csv-loader/metadata-provider-string.ts b/packages/galileo-cli/examples/csv-loader/metadata-provider-string.ts
@@ -7,7 +7,7 @@ import { parseCsv } from "./parser-common";
 import { DocumentMetadata, IMetadataProvider } from "../../src";
 
 export class MetadataProvider implements IMetadataProvider {
-  getMetadata(): string | DocumentMetadata {
+  async getMetadata(): Promise<string | DocumentMetadata> {
     // build the metadata
     const docMetadata = parseCsv();
 

diff --git a/packages/galileo-cli/src/lib/document/document-metadata.ts b/packages/galileo-cli/src/lib/document/document-metadata.ts
@@ -60,7 +60,7 @@ export const loadDocumentMetadata = async (
       const { MetadataProvider } = await import(loaderOrMetaFilePath);
       const metadataProvider: IMetadataProvider = new MetadataProvider();
 
-      const metadataReturned = metadataProvider.getMetadata();
+      const metadataReturned = await metadataProvider.getMetadata();
 
       if (typeof metadataReturned === "string") {
         metadataFile = metadataReturned;

diff --git a/packages/galileo-cli/src/lib/document/metadata-provider.ts b/packages/galileo-cli/src/lib/document/metadata-provider.ts
@@ -4,5 +4,5 @@ PDX-License-Identifier: Apache-2.0 */
 import { DocumentMetadata } from "../types";
 
 export interface IMetadataProvider {
-  readonly getMetadata: () => string | DocumentMetadata;
+  readonly getMetadata: () => Promise<string | DocumentMetadata>;
 }