Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/general #93

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

andrewcr7
Copy link
Contributor

Issue #77 , Closed events with empty endTime
Issue #70 , Chime message max size

Description of changes:
Pulling fixes for Issues 70&77, logging method, client caching, general cleanup of imports

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Chime has a 4096 byte limit for sent messages. Truncate any longer messages and indicate that the message is truncated. Fixes aws-samples#70
To reduce the number of boto3 clients that are created we introduce
AWSApi which uses functools.lru_cache to cache boto3 clients. This
can significantly reduce the lambda runtime.
Reduce the number of times we need to call the AWS api to fetch
secrets by caching the response.
@andrewcr7 andrewcr7 merged commit 727cc88 into aws-samples:fixes/general Oct 30, 2024
@andrewcr7 andrewcr7 mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants