Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing KeyError in script for activating glue triggers #23

Open
wants to merge 5 commits into
base: mainline
Choose a base branch
from

Conversation

nchylak
Copy link

@nchylak nchylak commented Jan 20, 2022

COMMIT a24c1b8

Issue #, if available:
n/a

Description of changes:
The lambda function was failing to activate the Glue triggers created due to a KeyError. Key should be triggerId (and not TriggerId) as specified in the properties of the three custom resources created in data-set-enrollment.ts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

COMMIT 6944b01

Issue #, if available:
n/a

Description of changes:
The property name used for creating the managed policy was not correct (policyName instead of managedPolicyName, see doc). As a result, the stack could still be deployed but the name of the managed policy was not applied.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nchylak and others added 5 commits January 20, 2022 17:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
NEB-374: add codeowners file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants