Fix inconstant iceberg default location due to final trailing slash #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working with Iceberg I noticed that the final / in the location of the table create weird extra / slash in the prefix of the objects in S3.
When using custom location of this type 's3://my_bucket/db/table' the issue doesn't persist.
Therefore I decided to use this default behaviour creating a
get_iceberg_locationto return default location without final /.The final slash makes my iceberg tables unreadable from trino, somehow athena seems dealing with it, as the glue/spark.
See this related issue apache/iceberg#4582.
Using version older then 0.13 fix the issue partially, as the metadata objects still suffer of the same problem (this must be addressed to the community developing Iceberg, I will reach out), for now that is the best fix to be able to use iceberg tables with other systems.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-glue next" section.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.