Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adjust the entrypoint to accept arguments and add version flag #19

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Feb 7, 2023

Summary

Changes

The goal of this PR is to modify the entry method to allow for easy passage of arguments to the parser method. This ensures we can easily test the function.

User experience

Only visible change to end users includes the capability to run: eksupgrade --version

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@mbeacom mbeacom self-assigned this Feb 7, 2023
@mbeacom mbeacom changed the title Adjust the entrypoint to accept arguments, add a version flag, and ad… refactor: Adjust the entrypoint to accept arguments and add version flag Feb 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 2.63% // Head: 10.45% // Increases project coverage by +7.82% 🎉

Coverage data is based on head (30fbb33) compared to base (c2bced9).
Patch coverage: 81.81% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##            main      #19      +/-   ##
=========================================
+ Coverage   2.63%   10.45%   +7.82%     
=========================================
  Files         10       10              
  Lines       1939     1942       +3     
=========================================
+ Hits          51      203     +152     
+ Misses      1888     1739     -149     
Impacted Files Coverage Δ
eksupgrade/cli.py 93.10% <81.81%> (+93.10%) ⬆️
eksupgrade/src/preflight_module.py 3.62% <0.00%> (+3.62%) ⬆️
eksupgrade/src/boto_aws.py 10.16% <0.00%> (+10.16%) ⬆️
eksupgrade/src/eksctlfinal.py 10.50% <0.00%> (+10.50%) ⬆️
eksupgrade/starter.py 11.05% <0.00%> (+11.05%) ⬆️
eksupgrade/src/eks_get_image_type.py 13.72% <0.00%> (+13.72%) ⬆️
eksupgrade/src/self_managed.py 14.85% <0.00%> (+14.85%) ⬆️
eksupgrade/src/latest_ami.py 19.23% <0.00%> (+19.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbeacom mbeacom merged commit 6fcd312 into aws-samples:main Feb 7, 2023
@mbeacom mbeacom deleted the adjust-entry-args branch February 7, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants