Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove email report functionality #60

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Feb 21, 2023

Summary

Resolves: #30

Changes

The goal of this PR is to remove email functionality from this CLI in favor of future local report generation.

User experience

The end user is executing a CLI. The CLI should output relevant details and optionally dump to a local report. This PR removes the email report entirely in favor of future report generation support.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@mbeacom mbeacom self-assigned this Feb 21, 2023
@mbeacom mbeacom changed the title Resolve #30 - Remove email report functionality fix: Remove email report functionality Feb 21, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it

@mbeacom mbeacom merged commit 07ee04e into aws-samples:main Feb 21, 2023
@mbeacom mbeacom deleted the fix-30-remove-email branch February 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Remove email reporting
2 participants