Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove patching of addon resources and associated static assets #62

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Feb 22, 2023

Summary

Resolves: #61

Changes

This PR changes the addon update functionality to no longer attempt to manually patch daemonsets or deployments of official addons that can lean on the EKS API to upgrade.

User experience

No change to user experience beyond it being more pleasant / faster and less error prone (since we aren't leaning on static assets).

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@mbeacom mbeacom requested review from bryantbiggs and a team February 22, 2023 21:28
@mbeacom mbeacom self-assigned this Feb 22, 2023
@mbeacom mbeacom changed the title Remove patching of addon resources and associated static assets fix: Remove patching of addon resources and associated static assets Feb 22, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 11.74% // Head: 21.12% // Increases project coverage by +9.38% 🎉

Coverage data is based on head (df18253) compared to base (c84d333).
Patch coverage: 81.01% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   11.74%   21.12%   +9.38%     
==========================================
  Files          10       12       +2     
  Lines        1711     1737      +26     
==========================================
+ Hits          201      367     +166     
+ Misses       1510     1370     -140     
Impacted Files Coverage Δ
eksupgrade/cli.py 92.30% <ø> (-0.29%) ⬇️
eksupgrade/src/preflight_module.py 4.41% <ø> (+0.47%) ⬆️
eksupgrade/starter.py 11.17% <0.00%> (ø)
eksupgrade/utils.py 100.00% <ø> (+45.45%) ⬆️
eksupgrade/src/eks_get_image_type.py 14.54% <11.11%> (+0.81%) ⬆️
eksupgrade/src/k8s_client.py 22.03% <66.66%> (+0.35%) ⬆️
eksupgrade/models/eks.py 86.41% <86.41%> (ø)
eksupgrade/__init__.py 100.00% <100.00%> (ø)
eksupgrade/models/base.py 100.00% <100.00%> (ø)
eksupgrade/src/boto_aws.py 10.20% <0.00%> (+0.04%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbeacom mbeacom merged commit 5d317a2 into aws-samples:main Feb 22, 2023
@mbeacom mbeacom deleted the remove-patching-addons branch February 22, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Manual patching of addon removal
3 participants