Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added workflows for running e2e checks on the latest version #83

Merged
merged 31 commits into from
Mar 19, 2023
Merged

feat: Added workflows for running e2e checks on the latest version #83

merged 31 commits into from
Mar 19, 2023

Conversation

quixoticmonk
Copy link
Contributor

@quixoticmonk quixoticmonk commented Mar 18, 2023

Summary

The PR is addressing the end to end tests for the eksupgrade utility for three base versions. The PR includes the tests below:

  • Test successful No Upgrade if the target version is the same as current eks version
  • Test successful addon upgrade for a target version matching the currently deployed cluster version
  • Test successful preflight checks for the next version of the eks control plane.
  • Test successful upgrade for the next version of the eks control plane.

The inputs are controlled to use three EKS clusters of versions 1.22 , 1.23 and 1.24.

Workflow options:

  • The workflow is currently utilizing eksctl to create clusters with Managed Node groups.
  • The workflow allows users to run the delete cluster on demand, if required.
  • Expects three user inputs
    • eksupgrade_version : set to latest by default; allows to test against the pypi version or the trunk based code.
    • trigger_tests : Choice of true or false to trigger cluster creation and running tests.
    • trigger_destroy: Choice of destroying active test clusters and be used as post step after tests when selected in conjunction with trigger_tests as true.
  • The workflow adds options to delete the cluster after completion of these tests.
    Screenshot 2023-03-18 at 3 29 13 PM

NOTE:: This requires a repository level secret named ROLE_TO_ASSUME

Resolves: #72

Changes

Provides the team maintaining the codebase to test the workflows against the latest version of eksupgrade or the latest code in main.

User experience

No changes to the end user.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (088bca6) 27.88% compared to head (4a02a4d) 27.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   27.88%   27.88%           
=======================================
  Files          13       13           
  Lines        1922     1922           
=======================================
  Hits          536      536           
  Misses       1386     1386           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbeacom mbeacom requested a review from a team March 18, 2023 18:50
@quixoticmonk quixoticmonk marked this pull request as ready for review March 19, 2023 02:42
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit 3a6fd98 into aws-samples:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Integration tests for code changes
3 participants